[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1170: DISPATCH-1679: Make qd_timer_cancel and qd_timer_free synchronous

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1170:
URL: https://github.com/apache/qpid-dispatch/pull/1170#discussion_r625121096



##########
File path: src/timer.c
##########
@@ -129,8 +214,9 @@ qd_timestamp_t qd_timer_now() {
 void qd_timer_schedule(qd_timer_t *timer, qd_duration_t duration)
 {
     sys_mutex_lock(lock);
-    timer_cancel_LH(timer);  // Timer is now on the idle list
-    DEQ_REMOVE(idle_timers, timer);
+

Review comment:
       If state is DELETED that indicates a bug where a codepath is attempting to schedule a timer that has been deleted.  Returning immediately would mask that bug - better to assert().




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org