You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/26 12:27:33 UTC

[GitHub] [pulsar] tjiuming commented on a diff in pull request #17398: [feat][offload] ADD offload_time_threshold policy (time-based offloading)

tjiuming commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r1005611375


##########
conf/broker.conf:
##########
@@ -1149,6 +1149,10 @@ managedLedgerOffloadDeletionLagMs=14400000
 # (default is -1, which is disabled)
 managedLedgerOffloadAutoTriggerSizeThresholdBytes=-1
 
+# The number of seconds before triggering automatic offload to long term storage
+# (default is -1, which is disabled)
+managedLedgerOffloadThresholdInSeconds=-1

Review Comment:
   There is a method `compatibleWithBrokerConfigFile` in OffloadPoliciesImpl.java. 
   The `managedLedgerOffloadAutoTriggerThresholdInBytes` has different names in `ServiceConfiguration` and `OffloadPoliciesImpl.java`. I don't keep align with `managedLedgerOffloadAutoTriggerSizeThresholdBytes` here is for the purpose of keep align with `OffloadPoliciesImpl.java`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org