You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by to...@apache.org on 2010/09/11 00:09:11 UTC
svn commit: r995999 - in /hbase/trunk: CHANGES.txt
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
Author: todd
Date: Fri Sep 10 22:09:11 2010
New Revision: 995999
URL: http://svn.apache.org/viewvc?rev=995999&view=rev
Log:
HBASE-2983. TestHLog unit test is mis-comparing an assertion (Alex Newman via Todd Lipcon)
Modified:
hbase/trunk/CHANGES.txt
hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
Modified: hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/trunk/CHANGES.txt?rev=995999&r1=995998&r2=995999&view=diff
==============================================================================
--- hbase/trunk/CHANGES.txt (original)
+++ hbase/trunk/CHANGES.txt Fri Sep 10 22:09:11 2010
@@ -518,6 +518,8 @@ Release 0.21.0 - Unreleased
HBASE-2974 LoadBalancer ArithmeticException: / by zero
HBASE-2975 DFSClient names in master and RS should be unique
HBASE-2978 LoadBalancer IndexOutOfBoundsException
+ HBASE-2983 TestHLog unit test is mis-comparing an assertion
+ (Alex Newman via Todd Lipcon)
IMPROVEMENTS
HBASE-1760 Cleanup TODOs in HTable
Modified: hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
URL: http://svn.apache.org/viewvc/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java?rev=995999&r1=995998&r2=995999&view=diff
==============================================================================
--- hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java (original)
+++ hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java Fri Sep 10 22:09:11 2010
@@ -522,7 +522,7 @@ public class TestHLog {
assertEquals(COL_COUNT, entry.getEdit().size());
int idx = 0;
for (KeyValue val : entry.getEdit().getKeyValues()) {
- assertTrue(Bytes.equals(hri.getRegionName(),
+ assertTrue(Bytes.equals(hri.getEncodedNameAsBytes(),
entry.getKey().getEncodedRegionName()));
assertTrue(Bytes.equals(tableName, entry.getKey().getTablename()));
assertTrue(Bytes.equals(row, val.getRow()));
@@ -535,7 +535,7 @@ public class TestHLog {
entry = reader.next();
assertEquals(1, entry.getEdit().size());
for (KeyValue val : entry.getEdit().getKeyValues()) {
- assertTrue(Bytes.equals(hri.getRegionName(),
+ assertTrue(Bytes.equals(hri.getEncodedNameAsBytes(),
entry.getKey().getEncodedRegionName()));
assertTrue(Bytes.equals(tableName, entry.getKey().getTablename()));
assertTrue(Bytes.equals(HLog.METAROW, val.getRow()));