You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jamesbroadhead <gi...@git.apache.org> on 2014/08/10 23:50:50 UTC
[GitHub] thrift pull request: python: Make message-writing more generic
GitHub user jamesbroadhead opened a pull request:
https://github.com/apache/thrift/pull/184
python: Make message-writing more generic
Make the use of oprot & self._oprot generic, to remove some complexity
from the generator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jamesbroadhead/thrift python_generic_oprot_02
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 2cc3e0e80ce8892c0ef2e77c3daf8f15424e2cad
Author: James Broadhead <jb...@twitter.com>
Date: 2014-08-10T18:58:17Z
python: Make message-writing more generic
Make the use of oprot & self._oprot generic, to remove some complexity
from the generator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: python: Make message-writing more generic
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: python: Make message-writing more generic
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/184#issuecomment-93616125
Thanks for your patch @jamesbroadhead, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---