You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Christophe JAILLET <ch...@wanadoo.fr> on 2019/10/20 16:10:40 UTC

Re: svn commit: r1868655 - /httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags

++1

Le 20/10/2019 à 17:33, ylavic@apache.org a écrit :
> Author: ylavic
> Date: Sun Oct 20 15:33:19 2019
> New Revision: 1868655
>
> URL: http://svn.apache.org/viewvc?rev=1868655&view=rev
> Log:
> update-log-msg-tags: allow to reference intended duplicate tags.
>
> Modified:
>      httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags
>
> Modified: httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags?rev=1868655&r1=1868654&r2=1868655&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags (original)
> +++ httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags Sun Oct 20 15:33:19 2019
> @@ -9,6 +9,8 @@ my $serial = read_serial($serial_file);
>   my $orig_serial = $serial;
>   my %tags;
>   
> +my %intended_duplicate_tags;
> +
>   foreach my $file (@ARGV) {
>       if ($file !~ /\.c$/) {
>           print STDERR "Skipping non-C file $file\n";
> @@ -124,7 +126,7 @@ sub note_tag
>               $oneline .= $1;
>           }
>       }
> -    if (exists $tags{$tag}) {
> +    if (exists $tags{$tag} and not exists $intended_duplicate_tags{$tag}) {
>           print STDERR "WARNING: Duplicate tag $tag at $tags{$tag}->{file}:$tags{$tag}->{line} and $file:$lineno\n";
>       }
>       if ($tag >= $serial) {
>