You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by gonzalad <gi...@git.apache.org> on 2017/02/28 12:45:05 UTC

[GitHub] cxf-fediz pull request #12: FEDIZ-192 - customSTSParameter propagation

GitHub user gonzalad opened a pull request:

    https://github.com/apache/cxf-fediz/pull/12

    FEDIZ-192 - customSTSParameter propagation

    This fix enables propagating the customSTSParameter
    SAML parameter to the Validator class.
    
    The issue was caused by Spring Security which redirects
    the user to a /login page (without the original parameters)
    
    To handle this case, we :
     * get the custom parameter from HTTP parameters
       (as previously).
     * if not found we lookup in the Spring Security
       savedRequest (aka requestCache).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gonzalad/cxf-fediz FEDIZ-192

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf-fediz/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 8760ca7259035d3381451973a8796591aaafa0be
Author: gonzalad <ad...@yahoo.fr>
Date:   2017-02-28T12:20:16Z

    FEDIZ-192 - customSTSParameter propagation
    
    This fix enables propagating the customSTSParameter
    SAML parameter to the Validator class.
    
    The issue was caused by Spring Security which redirects
    the user to a /login page (without the original parameters)
    
    To handle this case, we :
     * get the custom parameter from HTTP parameters
       (as previously).
     * if not found we lookup in the Spring Security
       savedRequest (aka requestCache).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf-fediz pull request #12: FEDIZ-192 - customSTSParameter propagation

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cxf-fediz/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf-fediz issue #12: FEDIZ-192 - customSTSParameter propagation

Posted by coheigea <gi...@git.apache.org>.
Github user coheigea commented on the issue:

    https://github.com/apache/cxf-fediz/pull/12
  
    Looks good thanks. Just one trivial change you could make...move the "HttpServletResponse response" declaration into the "if (authRealmParameter == null)" statement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---