[GitHub] [doris] AshinGau commented on a diff in pull request #22919: [enhancement](file-cache) limit the file cache handle num and init the file cache concurrently

["AshinGau (via GitHub)" <gi...@apache.org>]

AshinGau commented on code in PR #22919:
URL: https://github.com/apache/doris/pull/22919#discussion_r1292927338


##########
be/src/io/cache/block/block_file_cache.cpp:
##########
@@ -205,5 +207,21 @@ size_t IFileCache::file_reader_cache_size() {
     return s_file_name_to_reader.size();
 }
 
+void IFileCache::init() {
+    struct rlimit limit;
+    if (getrlimit(RLIMIT_NOFILE, &limit) != 0) {

Review Comment:
   So if failed to get the rlimit, `config::file_cache_max_file_reader_cache_size` will be not used to set `_max_file_reader_cache_size`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org