[jira] Commented: (FELIX-1993) Enhance configuration printer support

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803339#action_12803339 ] 

Felix Meschberger commented on FELIX-1993:
------------------------------------------

Patch looks fine.

Line 38 should probably read:
      String MODE_TXT = "txt" (was: String MODE_TXT = "zip")

> Enhance configuration printer support
> -------------------------------------
>
>                 Key: FELIX-1993
>                 URL: https://issues.apache.org/jira/browse/FELIX-1993
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>    Affects Versions: webconsole-2.0.4
>            Reporter: Carsten Ziegeler
>         Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2. 
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.