You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/05/25 03:09:39 UTC
[kudu-CR] [authn token expire-itest] minor clean-up
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6987
Change subject: [authn_token_expire-itest] minor clean-up
......................................................................
[authn_token_expire-itest] minor clean-up
This patch contains a couple of updates on authn_token_expire-itest:
* Increase authn token's TTL from 2 to 5 seconds in workload-related
test scenario to make it more stable when running with other
parallel activity.
* Do not call ExternalMiniCluster::Start() for slow scenarios to
to avoid wasting time if KUDU_ALLOW_SLOW_TESTS is not enabled.
* More relevant names for tests classes.
Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 35 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/6987/1
--
To view, visit http://gerrit.cloudera.org:8080/6987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [authn token expire-itest] minor clean-up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [authn_token_expire-itest] minor clean-up
......................................................................
[authn_token_expire-itest] minor clean-up
This patch contains a couple of updates on authn_token_expire-itest:
* Increase authn token's TTL from 2 to 5 seconds in workload-related
test scenario to make it more stable when running with other
parallel activity.
* Do not call ExternalMiniCluster::Start() for slow scenarios
to avoid wasting time if KUDU_ALLOW_SLOW_TESTS is not enabled.
* More relevant names for tests classes.
Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
Reviewed-on: http://gerrit.cloudera.org:8080/6987
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 36 insertions(+), 13 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [authn token expire-itest] minor clean-up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6987
to look at the new patch set (#3).
Change subject: [authn_token_expire-itest] minor clean-up
......................................................................
[authn_token_expire-itest] minor clean-up
This patch contains a couple of updates on authn_token_expire-itest:
* Increase authn token's TTL from 2 to 5 seconds in workload-related
test scenario to make it more stable when running with other
parallel activity.
* Do not call ExternalMiniCluster::Start() for slow scenarios
to avoid wasting time if KUDU_ALLOW_SLOW_TESTS is not enabled.
* More relevant names for tests classes.
Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 36 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/6987/3
--
To view, visit http://gerrit.cloudera.org:8080/6987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [authn token expire-itest] minor clean-up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [authn_token_expire-itest] minor clean-up
......................................................................
[authn_token_expire-itest] minor clean-up
This patch contains a couple of updates on authn_token_expire-itest:
* Increase authn token's TTL from 2 to 5 seconds in workload-related
test scenario to make it more stable when running with other
parallel activity.
* Do not call ExternalMiniCluster::Start() for slow scenarios
to avoid wasting time if KUDU_ALLOW_SLOW_TESTS is not enabled.
* More relevant names for tests classes.
Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
---
M src/kudu/integration-tests/authn_token_expire-itest.cc
1 file changed, 35 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/6987/2
--
To view, visit http://gerrit.cloudera.org:8080/6987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [authn token expire-itest] minor clean-up
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [authn_token_expire-itest] minor clean-up
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I437f2f72762c3a6e037792a511259734c8b0d860
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No