You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/28 07:22:21 UTC
[GitHub] [pulsar] leizhiyuan opened a new pull request, #17316: fix: bundle-data metadata leak because of bundlestats was not clean
leizhiyuan opened a new pull request, #17316:
URL: https://github.com/apache/pulsar/pull/17316
…#17095)
Co-authored-by: zhiyuanlei <zh...@tencent.com>
(cherry picked from commit e23a4c7135090d29c069e4ef8deb389f038c520d)
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #17316: [fix][broker]bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #17316: [fix][broker]bundle-data metadata leak because of bundlestats was not clean
URL: https://github.com/apache/pulsar/pull/17316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17316: [fix][broker] bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17316:
URL: https://github.com/apache/pulsar/pull/17316#issuecomment-1343731272
Closed as stale. You may resubmit the patch and fix CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17316: [fix][broker] bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17316:
URL: https://github.com/apache/pulsar/pull/17316#issuecomment-1314695108
cc @codelipenghui @Jason918 @congbobo184 do we include this patch for the next 2.9 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #17316: [fix][broker]bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17316:
URL: https://github.com/apache/pulsar/pull/17316#issuecomment-1232495557
Please follow Pulsar Pull Request Naming Convention Guide: https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #17316: [fix][broker] bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on PR #17316:
URL: https://github.com/apache/pulsar/pull/17316#issuecomment-1315442855
@tisonkun yes, hope it can be included in 2.9.4v. I see the test doesn't pass, seems this bug doesn't fix in this way. If the test can't be fixed before branch-2.9 cutting, it will be moved to 2.9.5v
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17316: [fix][broker]bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17316:
URL: https://github.com/apache/pulsar/pull/17316#issuecomment-1284820929
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun closed pull request #17316: [fix][broker] bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #17316: [fix][broker] bundle-data metadata leak because of bundlestats was not clean
URL: https://github.com/apache/pulsar/pull/17316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org