You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/10 20:44:15 UTC
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #184: Modernize IT plugins to use annotations
michael-o commented on code in PR #184:
URL: https://github.com/apache/maven-integration-testing/pull/184#discussion_r991616440
##########
core-it-suite/src/test/resources/mng-3703/project/pom.xml:
##########
@@ -19,7 +19,7 @@
<plugins>
<plugin>
<artifactId>maven-site-plugin</artifactId>
- <version>3.3</version>
+ <version>3.9.1</version>
Review Comment:
Does it make sense to move to a newer version here? 3.9.1 is old already.
##########
core-it-suite/src/test/resources-filtered/bootstrap.txt:
##########
@@ -122,34 +114,29 @@ org.apache.maven.resolver:maven-resolver-util:1.7.3
org.apache.maven.shared:maven-artifact-transfer:0.11.0
org.apache.maven.shared:maven-common-artifact-filters:3.1.0
org.apache.maven.shared:maven-shared-utils:3.3.3
-org.apache.maven.skins:maven-default-skin:1.0
-org.apache.maven.surefire:surefire-junit4:2.12.4
-org.apache.maven.surefire:surefire-junit4:2.22.0
-org.apache.maven.wagon:wagon-webdav-jackrabbit:2.0
+org.apache.maven.skins:maven-default-skin:1.3
+org.apache.maven.surefire:surefire-junit4:3.0.0-M7
org.apache.maven.wagon:wagon-webdav-jackrabbit:2.10
-org.apache.maven:maven-aether-provider:3.1.1
-org.apache.maven:maven-artifact-manager:2.1.0
-org.apache.maven:maven-core:3.1.0
-org.apache.maven:maven-core:3.3.1
-org.apache.maven:maven-model:2.1.0
+org.apache.maven.wagon:wagon-webdav:1.0-beta-2
Review Comment:
We must be rid of this ancient extension if possible. Likely separate PR.
##########
core-it-suite/src/test/resources/mng-4360/jackrabbit/pom.xml:
##########
@@ -47,7 +47,7 @@ under the License.
<extension>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-webdav-jackrabbit</artifactId>
- <version>2.0</version>
+ <version>2.10</version>
Review Comment:
See my comment in `bootstrap.txt`
##########
core-it-support/core-it-plugins/maven-it-plugin-parameter-implementation/pom.xml:
##########
@@ -42,7 +42,35 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
- <version>2.0</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven.plugin-tools</groupId>
+ <artifactId>maven-plugin-annotations</artifactId>
+ <version>3.6.5-20221006.213415-47</version>
+ <scope>provided</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-plugin-plugin</artifactId>
+ <version>3.6.5-20221006.213415-47</version>
Review Comment:
So this requires a snapshot and shouldn't be on master, right?
##########
core-it-suite/src/test/resources/mng-6506-package-annotation/plugin/pom.xml:
##########
@@ -27,21 +27,17 @@ under the License.
<version>0.1</version>
<packaging>maven-plugin</packaging>
- <properties>
- <maven-version>3.6.0</maven-version>
- </properties>
-
<dependencies>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
- <version>${maven-version}</version>
+ <version>3.3</version>
Review Comment:
3.6.4?
##########
core-it-suite/src/test/resources/mng-6189-site-reportPlugins-warning/pom.xml:
##########
@@ -52,7 +52,7 @@ under the License.
<reportPlugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-report-plugin</artifactId>
- <version>2.5</version>
+ <version>3.0.0-M5</version>
Review Comment:
M7?
##########
core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java:
##########
@@ -615,16 +615,16 @@ protected Verifier newVerifier( String basedir, String settings, boolean debug )
// Java9 requires at least 1.6
if ( VersionRange.createFromVersionSpec( "[9,12)" ).containsVersion( getJavaVersion() ) )
{
- verifier.getSystemProperties().put( "maven.compiler.source", "1.7" );
- verifier.getSystemProperties().put( "maven.compiler.target", "1.7" );
- verifier.getSystemProperties().put( "maven.compiler.release", "7" );
+ verifier.getSystemProperties().put( "maven.compiler.source", "1.8" );
+ verifier.getSystemProperties().put( "maven.compiler.target", "1.8" );
+ verifier.getSystemProperties().put( "maven.compiler.release", "8" );
}
// Java12 requires at least 7
if ( VersionRange.createFromVersionSpec( "[12,)" ).containsVersion( getJavaVersion() ) )
{
- verifier.getSystemProperties().put( "maven.compiler.source", "7" );
- verifier.getSystemProperties().put( "maven.compiler.target", "7" );
- verifier.getSystemProperties().put( "maven.compiler.release", "7" );
+ verifier.getSystemProperties().put( "maven.compiler.source", "8" );
+ verifier.getSystemProperties().put( "maven.compiler.target", "8" );
+ verifier.getSystemProperties().put( "maven.compiler.release", "8" );
}
Review Comment:
This distinction is useless by now, isn't it? Like the TLS version setting.
##########
core-it-suite/src/test/resources/mng-5561-plugin-relocation-loses-configuration/old-plugin-with-relocation/pom.xml:
##########
@@ -9,8 +9,8 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <maven.compiler.source>1.7</maven.compiler.source>
- <maven.compiler.target>1.7</maven.compiler.target>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
<maven-version>3.1.0</maven-version>
Review Comment:
Is this used in deps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org