[jira] [Commented] (AIRFLOW-3527) Cloud SQL proxy with UNIX sockets might lead to too long socket path

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734145#comment-16734145 ] 

ASF GitHub Bot commented on AIRFLOW-3527:
-----------------------------------------

kaxil commented on pull request #4350: [AIRFLOW-3527] Cloud SQL Proxy has shorter path for UNIX socket
URL: https://github.com/apache/incubator-airflow/pull/4350
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cloud SQL proxy with UNIX sockets might lead to too long socket path
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-3527
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3527
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> Currently Cloud SQL Proxy with UNIX sockets creates the proxy dir in /tmp/\{UDID1}/folder - which in case of postgres and long instance names might lead to too long name of UNIX socket (the path length for socket is limited to 108 characters in Linux). [http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_un.h.html#tag_13_67_04]
> However in case instance name is long enough that leads to too long path (which turns to be fairly short - instance names can often exceed 20-30 characters)  and a cryptic "invalid path name" error. Therefor we need to 
> 1) generate the path with shorter random number prefix. 8 characters should be random enough + we can check if the generated path did not exist already and generate another one if that's the case.
> 2) fail validation in case the generated path is too long and propose a solution (shorter names or switching to TCP).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)