You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Otavio Rodolfo Piske (Jira)" <ji...@apache.org> on 2023/01/16 16:06:00 UTC

[jira] [Comment Edited] (CAMEL-18936) components - Add log4j-core so logging to logfile works

    [ https://issues.apache.org/jira/browse/CAMEL-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677457#comment-17677457 ] 

Otavio Rodolfo Piske edited comment on CAMEL-18936 at 1/16/23 4:05 PM:
-----------------------------------------------------------------------

SinceĀ  these are so extensively used, I am wondering if it would be worth to do one of the following:

1. Either include them to components/pom.xml and let the components inherit it. In case we have conflicts, we may be able to override on the specific components.
2. Or, define a core/camel-test-parent/pom.xml component and define these (and a few others there - it may be useful for JUnit too, as well as for assert4j, Hamcrest, Awaitility, etc). Then we can just import the bom. 

What do you think?


was (Author: orpiske):
SinceĀ  these are so extensively used, I am wondering if it would be worth to do one of the following:

1. Either include them to components/pom.xml and let the components inherit it. In case we have conflicts, we may be able to override on the specific components.
2. Or, define a core/camel-test-parent/pom.xml component and define these (and a few others there - it may be useful for JUnit too, as well as for assert4j, Hamcrest, Awaitility, etc). 

What do you think?

> components - Add log4j-core so logging to logfile works
> -------------------------------------------------------
>
>                 Key: CAMEL-18936
>                 URL: https://issues.apache.org/jira/browse/CAMEL-18936
>             Project: Camel
>          Issue Type: Task
>            Reporter: Claus Ibsen
>            Assignee: Andrea Cosentino
>            Priority: Major
>             Fix For: 4.0
>
>
> To make logging work we need to make sure we have these 2 test dependencies
> {code}
>         <dependency>
>             <groupId>org.apache.logging.log4j</groupId>
>             <artifactId>log4j-core</artifactId>
>             <scope>test</scope>
>         </dependency>
>         <dependency>
>             <groupId>org.apache.logging.log4j</groupId>
>             <artifactId>log4j-slf4j2-impl</artifactId>
>             <scope>test</scope>
>         </dependency>
> {code}
> Most often we only have
> {code}
>         <dependency>
>             <groupId>org.apache.logging.log4j</groupId>
>             <artifactId>log4j-slf4j2-impl</artifactId>
>             <scope>test</scope>
>         </dependency>
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)