You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org> on 2023/08/11 04:20:19 UTC
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #24921: feat(gsheets): file upload
Antonio-RiveroMartnez commented on code in PR #24921:
URL: https://github.com/apache/superset/pull/24921#discussion_r1290878333
##########
superset/db_engine_specs/gsheets.py:
##########
@@ -57,7 +71,7 @@ class GSheetsParametersSchema(Schema):
class GSheetsParametersType(TypedDict):
service_account_info: str
- catalog: Optional[dict[str, str]]
+ catalog: dict[str, str] | None
Review Comment:
Just curious why moving from `Optional` ? Because I see `Optional` being used in several other `TypedDict` classes. Want to confirm if this is a pattern we aim to follow moving forward, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org