[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #475: [improve][doc] Add broker level metrics statistics and expose to prometheus

["Anonymitaet (via GitHub)" <gi...@apache.org>]

Anonymitaet commented on code in PR #475:
URL: https://github.com/apache/pulsar-site/pull/475#discussion_r1145540207


##########
docs/reference-metrics.md:
##########
@@ -148,6 +148,19 @@ All the broker metrics are labeled with the following labels:
 | pulsar_connection_closed_total_count | Gauge | The total number of closed connections. |
 | pulsar_broker_throttled_connections | Gauge | The number of throttled connections. |
 | pulsar_broker_throttled_connections_global_limit | Gauge | The number of throttled connections due to per-connection limit. |
+| pulsar_broker_topics_count | Gauge | The number of Pulsar topics in this broker. |
+| pulsar_broker_subscriptions_count | Gauge | The number of Pulsar subscriptions in this broker. |
+| pulsar_broker_producers_count | Gauge | The number of active producers connected to this broker. |
+| pulsar_broker_consumers_count | Gauge | The number of active consumers connected to this broker. |
+| pulsar_broker_rate_in | Gauge | The total message rate coming into this broker (message per second). |
+| pulsar_broker_rate_out | Gauge | The total message rate going out from this broker (message per second). |
+| pulsar_broker_throughput_in | Gauge | The total throughput coming into this broker (byte per second). |
+| pulsar_broker_throughput_out | Gauge | The total throughput going out from this broker (byte per second). |
+| pulsar_broker_storage_size | Gauge | The total storage size of all topics in this broker (bytes). |

Review Comment:
   ```suggestion
   | pulsar_broker_storage_size | Gauge | The total storage size of all topics in this broker (in bytes). |
   ```
   Keep consistent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org