You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/06 15:01:53 UTC
[GitHub] [pulsar] anshubansal27 opened a new pull request #11237: Fix aws token caching
anshubansal27 opened a new pull request #11237:
URL: https://github.com/apache/pulsar/pull/11237
Issue : Temporary Token is cached for the offloading and AWS refreshes the token around every 6 hours and offloading is getting failed with Expired Token Issue Error.
Resolution: I am just removing the caching part of the token and every time calling the AWS API : refresh might be already handled inside AWS SDK code and therefore this additional check might not be required.
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11237: Fix aws token caching
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11237:
URL: https://github.com/apache/pulsar/pull/11237#issuecomment-995061313
@anshubansal27 - do you plan on providing an update to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #11237: Fix aws token caching
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #11237:
URL: https://github.com/apache/pulsar/pull/11237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11237: Fix aws token caching
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11237:
URL: https://github.com/apache/pulsar/pull/11237#issuecomment-999932292
Closing for now due to inactivity. Please re-open if you're able to complete this contribution. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11237: Fix aws token caching
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11237:
URL: https://github.com/apache/pulsar/pull/11237#issuecomment-875209691
@anshubansal27 thanks for your contribution. For this PR, do we need to update docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11237: Fix aws token caching
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #11237:
URL: https://github.com/apache/pulsar/pull/11237#discussion_r684528882
##########
File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java
##########
@@ -279,47 +279,47 @@ public ProviderMetadata getProviderMetadata() {
};
static final CredentialBuilder AWS_CREDENTIAL_BUILDER = (TieredStorageConfiguration config) -> {
- if (config.getCredentials() == null) {
- final AWSCredentialsProvider authChain;
- try {
- if (Strings.isNullOrEmpty(config.getConfigProperty(S3_ROLE_FIELD))) {
- authChain = DefaultAWSCredentialsProviderChain.getInstance();
+// if (config.getCredentials() == null) {
Review comment:
Just a comment on style here: in a future PR, I recommend removing this line. Its record will be stored in git history, and there isn't any need to keep it for future reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org