You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "LXin96 (via GitHub)" <gi...@apache.org> on 2023/12/18 14:09:11 UTC
[PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
LXin96 opened a new pull request, #10354:
URL: https://github.com/apache/hudi/pull/10354
### Change Logs
when async clustering start, currently if satisfy the delta-commit, it will generate clustering plan. however, when last clustering plan isn't completed, the next clustering plan will also schedule, maybe we can support a param to controll the max pending cluster plan num.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1865159115
> > we should better not to schedule the next.
>
> When data volumn is huge, wouldn't it be better we have more smaller plans than much bigger ones?
+1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1864428120
> we should better not to schedule the next.
When data volumn is huge, wouldn't it be better we have more smaller plans than much bigger ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1862074307
Can you elaborate a little more what we gain by introducing the param here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1860880850
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565",
"triggerID" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"triggerType" : "PUSH"
}, {
"hash" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565)
* e191cc088f2231734256194b8e9c1bd69b17d475 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1986917093
Closing this PR as the current behavior is expected. @LXin96 feel free to reopen the PR if you have better reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua closed pull request #10354: [HUDI-7239] add maxPendingClusteringPlanNums for clustering
URL: https://github.com/apache/hudi/pull/10354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1861391386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565",
"triggerID" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"triggerType" : "PUSH"
}, {
"hash" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21566",
"triggerID" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e191cc088f2231734256194b8e9c1bd69b17d475 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21566)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1860745667
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565",
"triggerID" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "LXin96 (via GitHub)" <gi...@apache.org>.
LXin96 commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1862396432
en , ok. When I test clustering, in generally, a clustering plan generated, we should process the first clustering plan's substask, however i find that when the last clustering plan's subtask aren't finished, the next clustering plan's subtask also start to run. So I hope a param to control the clustering plan count, when the last clustering plan's subtask aren't all finished, we should better not to schedule the next. when flink job is huge data to clustering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1860717179
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1905333494
Since, the current behavior is expected, let me know if it is ok to close this PR
Thanks,
Balaji.V
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1860901967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565",
"triggerID" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"triggerType" : "PUSH"
}, {
"hash" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21566",
"triggerID" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565)
* e191cc088f2231734256194b8e9c1bd69b17d475 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21566)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7239] add maxPendingClusteringPlanNums for clustering [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10354:
URL: https://github.com/apache/hudi/pull/10354#issuecomment-1861058495
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565",
"triggerID" : "bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a",
"triggerType" : "PUSH"
}, {
"hash" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21566",
"triggerID" : "e191cc088f2231734256194b8e9c1bd69b17d475",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0c5f0d78068e3ace80a5ce79fd75f3df6b474a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21565)
* e191cc088f2231734256194b8e9c1bd69b17d475 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21566)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org