You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/04 15:46:43 UTC

[GitHub] [pulsar] cckellogg commented on a change in pull request #3980: fix: bug when function auth is not enabled

cckellogg commented on a change in pull request #3980: fix: bug when function auth is not enabled
URL: https://github.com/apache/pulsar/pull/3980#discussion_r272245467
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java
 ##########
 @@ -153,9 +153,13 @@ RuntimeSpawner getRuntimeSpawner(Function.Instance instance, String packageFile)
         int instanceId = instance.getInstanceId();
 
         FunctionDetails.Builder functionDetailsBuilder = FunctionDetails.newBuilder(functionMetaData.getFunctionDetails());
+        
 
 Review comment:
   can we add a unit test for this and or some comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services