Re: [PR] NIFI-13327: Allow migrating properties of Parameter Providers [nifi]

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory commented on code in PR #9080:
URL: https://github.com/apache/nifi/pull/9080#discussion_r1702962890


##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##########
@@ -265,6 +265,8 @@ public void synchronize(final ProcessGroup group, final VersionedExternalFlow ve
                     service.migrateConfiguration(originalPropertyValues, serviceFactory);
                 } else if (extension instanceof final ReportingTaskNode task) {
                     task.migrateConfiguration(originalPropertyValues, serviceFactory);
+                } else if (extension instanceof final ParameterProviderNode parameterProvider) {
+                    parameterProvider.migrateConfiguration(originalPropertyValues, serviceFactory);

Review Comment:
   @takraj This conditional never appears to be fired because Parameter Providers are never added to Created Extensions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org