You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/01 13:12:54 UTC
[GitHub] [ignite] nizhikov opened a new pull request #8963: IGNITE-14463 Support of testing Ignite based products with ducktape tests
nizhikov opened a new pull request #8963:
URL: https://github.com/apache/ignite/pull/8963
This PR allows to run ducktape tests for third party Ignite based tests.
* With `DOCKER_OPTIONS` user can specify additional mount points for docker image.
* `project` name can be specified in globals to run tests for another product.
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #8963: IGNITE-14463 Support of testing Ignite based products with ducktape tests
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8963:
URL: https://github.com/apache/ignite/pull/8963#discussion_r606066677
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -87,19 +88,22 @@ def config_template(self):
return IgniteClientConfigTemplate()
return IgniteServerConfigTemplate()
- def __home(self, version=None):
+ def __home(self, version=None, project=None):
"""
Get home directory for current spec.
"""
+ project = self.project if project is None else project
Review comment:
Fixed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #8963: IGNITE-14463 Support of testing Ignite based products with ducktape tests
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #8963:
URL: https://github.com/apache/ignite/pull/8963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] x-kreator commented on a change in pull request #8963: IGNITE-14463 Support of testing Ignite based products with ducktape tests
Posted by GitBox <gi...@apache.org>.
x-kreator commented on a change in pull request #8963:
URL: https://github.com/apache/ignite/pull/8963#discussion_r605866414
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -87,19 +88,22 @@ def config_template(self):
return IgniteClientConfigTemplate()
return IgniteServerConfigTemplate()
- def __home(self, version=None):
+ def __home(self, version=None, project=None):
"""
Get home directory for current spec.
"""
+ project = self.project if project is None else project
Review comment:
May be better is `project = project if project else self.project`, as at code below with version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org