[jira] [Resolved] (HBASE-27553) SlowLog does not include params for Mutations

["Bryan Beaudreault (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-27553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Beaudreault resolved HBASE-27553.
---------------------------------------
    Fix Version/s: 2.6.0
                   2.4.18
                   2.5.6
                   3.0.0-beta-1
                   4.0.0-alpha-1
       Resolution: Fixed

Pushed to all active branches. Thanks Ray!

> SlowLog does not include params for Mutations
> ---------------------------------------------
>
>                 Key: HBASE-27553
>                 URL: https://issues.apache.org/jira/browse/HBASE-27553
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Bryan Beaudreault
>            Assignee: Ray Mattingly
>            Priority: Minor
>             Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1, 4.0.0-alpha-1
>
>
> SlowLog params are extracted via [ProtobufUtil.getSlowLogParams|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L2154]. This method has various if/else branches for each request type, but mutation (the line linked above) is incorrect. Currently it handles MutationProto, but it should be MutateRequest. A MutationProto is never passed into this method, only MutateRequests so any MutateRequests being passed in now will fall through to the default case which contains nothing useful about the request.
> As part of fixing this, we should also ensure that we extract the region name from the MutateRequest to add into the SlowLogParams object like all the other requests.
> While we are here, the CoprocessorServiceRequest (handled further down) has a getRegion() method, but that is not passed into the SlowLogParams either. We should add that too.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)