You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "quic-sanirudh (via GitHub)" <gi...@apache.org> on 2023/02/17 13:12:54 UTC
[GitHub] [tvm] quic-sanirudh opened a new pull request, #14023: [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace
quic-sanirudh opened a new pull request, #14023:
URL: https://github.com/apache/tvm/pull/14023
A mismatch between the blocks present in the `result` vs the blocks passed in `block_sref_to_reuse` caused the bug mentioned in #13974.
This patch tries to fix that bug by collecting only the blocks that are part of result and also present in the block replacement map `new_block_to_old_`. Since the scope block is `result`, only that block and its child blocks would be replaced, and any replaced block would be present in `rewriter.new_block_to_old_`. Thus, collecting the replaced blocks from among child blocks of `result` guarantees that the `block_sref_reuse` would contain all the replaced blocks and that they'll point to the correct block in `result` thus avoiding the missing SRef error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14023: [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14023:
URL: https://github.com/apache/tvm/pull/14023#issuecomment-1434634580
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Hzfengsy, @junrushao, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on pull request #14023: [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace
Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh commented on PR #14023:
URL: https://github.com/apache/tvm/pull/14023#issuecomment-1434680184
> Please add a regression test for it
Yes, I realized that I did not add the test after creating the PR. I'll update with the test, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a diff in pull request #14023: [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on code in PR #14023:
URL: https://github.com/apache/tvm/pull/14023#discussion_r1109793385
##########
src/tir/schedule/primitive/layout_transformation.cc:
##########
@@ -704,6 +704,42 @@ class TransformLayoutPlanner : private StmtExprVisitor {
Buffer old_buffer_;
};
+/**
+ * @brief Collect blocks that are part of root block to be passed to ScheduleState::Replace for SRef
Review Comment:
```suggestion
/*!
* \brief Collect blocks that are part of root block to be passed to ScheduleState::Replace for SRef
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #14023: [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #14023:
URL: https://github.com/apache/tvm/pull/14023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh commented on a diff in pull request #14023: [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace
Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh commented on code in PR #14023:
URL: https://github.com/apache/tvm/pull/14023#discussion_r1109976749
##########
src/tir/schedule/primitive/layout_transformation.cc:
##########
@@ -704,6 +704,42 @@ class TransformLayoutPlanner : private StmtExprVisitor {
Buffer old_buffer_;
};
+/**
+ * @brief Collect blocks that are part of root block to be passed to ScheduleState::Replace for SRef
Review Comment:
Done thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org