[GitHub] [cloudstack] richardlawley commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

[GitBox <gi...@apache.org>]

richardlawley commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic
URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-508402874
 
 
   @rhtyd This is ready now.  I don't the travis failures can be related to this.
   
   This change will likely prevent CS from being able to add Port Forwarding rules on the originally supported 10.4 version due to the change in syntax for destination nat rules.  It has been tested on an SRX345 running JUNOS 15.1X49-D170.4.  I cannot find documentation for which version of JunOS introduced the changes - related changes came in 11.4 to static NAT.
   
   I had originally intended to also improve the handling of port forwarding rules where port ranges are specified - currently this uses 2 rules + 1 dest nat pool for every port, which might become a problem if a large range is specified.  However, documentation on the port ranges is very unclear from Juniper, and this would also significantly complicate the PR.  I may revisit it in future if we find it problematic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services