You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/14 22:03:30 UTC

[GitHub] [commons-digester] nhojpatrick opened a new pull request #7: JUnit assertThrows

nhojpatrick opened a new pull request #7:
URL: https://github.com/apache/commons-digester/pull/7


   Code could be cleaner if it could be Java 1.8.
   
   I could set `<maven.compiler.testSource>1.8</maven.compiler.testSource>`... thoughts???


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-digester] nhojpatrick commented on pull request #7: JUnit assertThrows

Posted by GitBox <gi...@apache.org>.

nhojpatrick commented on pull request #7:
URL: https://github.com/apache/commons-digester/pull/7#issuecomment-710923812


   Ready to be merged, only looking at replacing `@Test(expected = Exception.class)` with `assertThrows` in this pr. I will raise another pr to cover replacing `try/catch/fail` blocks with `assertThrows` at a latest date.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org