You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/12 01:24:43 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #6368: [HUDI-4603] Improve HMS Catalog function in flink

danny0405 commented on code in PR #6368:
URL: https://github.com/apache/hudi/pull/6368#discussion_r944050014


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -893,7 +893,13 @@ private Map<String, String> supplementOptions(
     } else {
       Map<String, String> newOptions = new HashMap<>(options);
       // set up hive sync options
-      newOptions.put(FlinkOptions.HIVE_SYNC_ENABLED.key(), "true");
+      if (!newOptions.containsKey(FlinkOptions.HIVE_SYNC_ENABLED.key())) {
+        newOptions.put(FlinkOptions.HIVE_SYNC_ENABLED.key(), "true");
+      }
+      if (newOptions.containsKey(FlinkOptions.HIVE_STYLE_PARTITIONING.key())
+          && "true".equals(newOptions.get(FlinkOptions.HIVE_STYLE_PARTITIONING.key()))) {
+        newOptions.put(FlinkOptions.HIVE_SYNC_PARTITION_EXTRACTOR_CLASS_NAME.key(), "org.apache.hudi.hive.HiveStylePartitionValueExtractor");

Review Comment:
   Do we need this ? We already so the inference in `HoodieTableFactory`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org