You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/07/03 09:38:51 UTC

[GitHub] [jena] afs commented on a diff in pull request #1420: GH-1419: fix DatasetGraphMap#clear

afs commented on code in PR #1420:
URL: https://github.com/apache/jena/pull/1420#discussion_r912459282


##########
jena-arq/src/test/java/org/apache/jena/sparql/core/TestTestDatasetGraphMap.java:
##########
@@ -0,0 +1,9 @@
+package org.apache.jena.sparql.core;
+
+public class TestTestDatasetGraphMap extends AbstractDatasetGraphTests {

Review Comment:
   "TestTest" -> "Test".
   
   This also needs adding to `TS_Core` which it might a well go second in the list.
   



##########
jena-arq/src/test/java/org/apache/jena/sparql/core/AbstractDatasetGraphTests.java:
##########
@@ -328,6 +328,26 @@
         assertFalse(dsg.containsGraph(gn)) ;
     }
 
+    @Test public void clear_02() {
+        DatasetGraph dsg = emptyDataset();
+        dsg.add(new Quad(NodeFactory.createURI("g1"),

Review Comment:
   FYI: no need to change anything:
   
   For writing test data, you can use "SSE.parse...."
   
   ```
   dsg.add(SSE.parseQuad("(<g1> <a1> <b1> <c1>)"));
   ```
   
   The default graph is "_":
   
   ```
   dsg.add(SSE.parseQuad("(_ <a0> <b0> <c0>)"));
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org