[GitHub] [zookeeper] nkalmar commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling

[GitBox <gi...@apache.org>]

nkalmar commented on a change in pull request #1051: ZOOKEEPER-3503: Add server side large request throttling
URL: https://github.com/apache/zookeeper/pull/1051#discussion_r317171034
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -1358,6 +1395,85 @@ static void setMaxBatchSize(int size) {
         maxBatchSize = size;
     }
 
+    private void initLargeRequestThrottlingSettings() {
+        setLargeRequestMaxBytes(Integer.getInteger("zookeeper.largeRequestMaxBytes", 100 * 1024 * 1024));
 
 Review comment:
   Why not just use the already defined largeRequestMaxBytes int here for default value?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services