[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #2563: Fix for CASSANDRA-18688: Limit Java runtime in 5.0 to JDK17 in scripts; add a flag to opt out of that

["ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>]

ekaterinadimitrova2 commented on code in PR #2563:
URL: https://github.com/apache/cassandra/pull/2563#discussion_r1290626894


##########
bin/cassandra:
##########
@@ -276,6 +280,19 @@ if [ "x$allow_root" != "xyes" ] ; then
     fi
 fi
 
+if  [ "$short" \< "11" ];then
+    echo "Cassandra 5.0 requires Java 11 or Java 17."
+    exit 1;
+fi
+
+java_versions_supported=11,17
+supported=$(echo "$java_versions_supported" | tr "," '\n' | grep -F -x "$short")
+if [ "x$allow_experimental_java_ver" != "xyes" ] && [ "x$supported" = "x" ] ; then
+    echo "Experimental Java version not allowed: Cassandra 5.0 requires Java 11 or Java 17."
+    echo "If you would like to test with this version, use -J command line option"

Review Comment:
   ```suggestion
       echo "Cassandra 5.0 requires Java 11 or Java 17."
       echo "If you would like to test running Cassandra on non-LTS post JDK11 version, you can start it by adding -J command line option"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org