[Impala-ASF-CR] IMPALA-10593: Conditionally skip runtime filter for outer joins

["Steve Carlin (Code Review)" <ge...@cloudera.org>]

Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17200 )

Change subject: IMPALA-10593: Conditionally skip runtime filter for outer joins
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17200/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17200/1//COMMIT_MSG@7
PS1, Line 7: ...
> nit: instead of ... maybe reword it as 'Conditionally skip runtime filter f
Done


http://gerrit.cloudera.org:8080/#/c/17200/1//COMMIT_MSG@9
PS1, Line 9: ...when Expr not constant after null substitution.
> then this can be removed.
Done


http://gerrit.cloudera.org:8080/#/c/17200/1//COMMIT_MSG@14
PS1, Line 14: A third party tool needs
> nit: For external FE (to be consistent with other patches with similar exte
Done


http://gerrit.cloudera.org:8080/#/c/17200/1//COMMIT_MSG@16
PS1, Line 16: nulls, the result will be to not generate a runtime filter for that Expr.
> Add a 'Testing:' section here and provide the test query and indicate that 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46462e2030731d97c4c88e364148c0093c025ab3
Gerrit-Change-Number: 17200
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Mar 2021 00:04:29 +0000
Gerrit-HasComments: Yes