[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7908: arch/arm/samv7: use in application programming in EEFC code

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #7908:
URL: https://github.com/apache/nuttx/pull/7908#discussion_r1055238001


##########
arch/arm/src/samv7/sam_eefc.c:
##########
@@ -66,6 +66,20 @@
  * Private Functions
  ****************************************************************************/
 
+static uint32_t __ramfunc__ sam_iap(uint32_t cmd)
+{
+  uint32_t status;
+  irqstate_t flags;
+
+  flags = up_irq_save();

Review Comment:
   I will try to dump a ROM code to see. I'm expecting that IAP may execute multiple instructions and the flash re-programming requirement is that no code should be executed from flash during reprogramming, so `up_irq_save` is here to ensure there will be no interrupt during IAP execution.
   Let me convert to draft while I'm figuring out all the details



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org