You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/17 06:01:08 UTC
[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull
request #3999: #3968,
Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
tuohai666 commented on a change in pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999#discussion_r367780624
##########
File path: sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/execute/MySQLComStmtExecutePacket.java
##########
@@ -86,7 +86,7 @@ public MySQLComStmtExecutePacket(final MySQLPacketPayload payload) throws SQLExc
} else {
nullBitmap = null;
newParametersBoundFlag = null;
- parameters = null;
+ parameters = new ArrayList<>(0);;
Review comment:
Yes, it's better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services