You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/11 19:39:24 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #7289: fix: propagate color mapping from dashboard to charts

codecov-io commented on issue #7289: fix: propagate color mapping from dashboard to charts
URL: https://github.com/apache/incubator-superset/pull/7289#issuecomment-482276506
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7289?src=pr&el=h1) Report
   > Merging [#7289](https://codecov.io/gh/apache/incubator-superset/pull/7289?src=pr&el=desc) into [lyftga](https://codecov.io/gh/apache/incubator-superset/commit/65cc0e513c4aa7e82e1900639bb840533d820883?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `46.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7289/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7289?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           lyftga    #7289      +/-   ##
   ==========================================
   - Coverage   64.58%   64.57%   -0.02%     
   ==========================================
     Files         425      426       +1     
     Lines       20884    20898      +14     
     Branches     2297     2297              
   ==========================================
   + Hits        13488    13494       +6     
   - Misses       7270     7278       +8     
     Partials      126      126
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7289?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et/assets/src/explore/components/controls/index.js](https://codecov.io/gh/apache/incubator-superset/pull/7289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvaW5kZXguanM=) | `100% <ø> (ø)` | :arrow_up: |
   | [...et/assets/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/7289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xQYW5lbHMvRGVja1NjYXR0ZXIuanM=) | `0% <ø> (ø)` | :arrow_up: |
   | [...rset/assets/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xQYW5lbHMvc2VjdGlvbnMuanN4) | `100% <ø> (ø)` | :arrow_up: |
   | [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.06% <0%> (-0.34%)` | :arrow_down: |
   | [...shboard/util/charts/getFormDataWithExtraFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/7289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9jaGFydHMvZ2V0Rm9ybURhdGFXaXRoRXh0cmFGaWx0ZXJzLmpz) | `90% <100%> (+1.11%)` | :arrow_up: |
   | [superset/assets/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9DaGFydC5qc3g=) | `90.9% <100%> (ø)` | :arrow_up: |
   | [...rc/explore/components/controls/ColorMapControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQ29sb3JNYXBDb250cm9sLmpzeA==) | `36.36% <36.36%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7289?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7289?src=pr&el=footer). Last update [65cc0e5...85961e4](https://codecov.io/gh/apache/incubator-superset/pull/7289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org