[GitHub] [mina-sshd] ianw commented on issue #319: SshChannelNotFoundException: Received SSH_MSG_CHANNEL_WINDOW_ADJUST on unassigned channel 0 (last assigned=null)

["ianw (via GitHub)" <gi...@apache.org>]

ianw commented on issue #319:
URL: https://github.com/apache/mina-sshd/issues/319#issuecomment-1421761833

   Thanks for looking!
   
   > Could it be possible that there is a race between the server not receiving anything for some time, hitting some timeout and closing the session on that timeout, but just then getting the window adjustment after already having closed the previously opened channel? Perhaps Gerrit could also log `channelClosed()` events in its `ChannelIdTrackingUnknownChannelReferenceHandler`?
   
   Does the change https://gerrit-review.googlesource.com/c/gerrit/+/357694 look about right to you?  We can run with something like this (it will take me a bit to patch and deploy it, but we are seeing it regularly, so I think we have a high chance of hitting it).
   
   > I do notice that `LAST_CHANNEL_ID_KEY` is public -- are we 100% sure that no other code removes this key? 
   
   I would say as close to 100% as possible :)  Certainly there's nothing else touching it from inspecting the gerrit source I can see.
   
   > Debug logs might tell more. (And confirm or debunk that theory.)
   
   I can turn up ```com.google.gerrit.sshd.ChannelIdTrackingUnknownChannelReferenceHandler: INFO``` -- I think that needs the above change to be helpful and log the other events.  Is there any other handler you'd suggest helpful too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org