[GitHub] [ignite-3] tledkov-gridgain commented on a change in pull request #639: IGNITE-16201 JDBC: Batch execution

[GitBox <gi...@apache.org>]

tledkov-gridgain commented on a change in pull request #639:
URL: https://github.com/apache/ignite-3/pull/639#discussion_r805768553



##########
File path: modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java
##########
@@ -164,8 +169,65 @@ public JdbcQueryEventHandlerImpl(QueryProcessor processor, JdbcMetadataCatalog m
     /** {@inheritDoc} */
     @Override
     public CompletableFuture<BatchExecuteResult> batchAsync(BatchExecuteRequest req) {
-        return CompletableFuture.completedFuture(new BatchExecuteResult(UNSUPPORTED_OPERATION,
-                "ExecuteBatch operation is not implemented yet."));
+        final Query firstQuery = req.queries().get(0);
+        if (CollectionUtils.nullOrEmpty(firstQuery.args())) {

Review comment:
       Design of the BatchExecuteRequest + Query is ambiguous for me.
   The request contains Query collection and eqach query may contain collection of batched arguments.
   Can we split them into two requests: BatchExecuteRequest, PreparedBatchExecuteRequest?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org