You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2008/11/18 15:37:41 UTC
svn commit: r718620 - in
/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment:
AttachmentDeserializer.java AttachmentUtil.java MimeBodyPartInputStream.java
Author: dkulp
Date: Tue Nov 18 06:37:41 2008
New Revision: 718620
URL: http://svn.apache.org/viewvc?rev=718620&view=rev
Log:
[CXF-1918, CXF-1916] Performance enhancments for mime attachments
Modified:
cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentDeserializer.java
cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java
cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java
Modified: cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentDeserializer.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentDeserializer.java?rev=718620&r1=718619&r2=718620&view=diff
==============================================================================
--- cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentDeserializer.java (original)
+++ cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentDeserializer.java Tue Nov 18 06:37:41 2008
@@ -58,6 +58,7 @@
private boolean lazyLoading = true;
+ private int pbAmount = 2048;
private PushbackInputStream stream;
private byte boundary[];
@@ -106,7 +107,7 @@
boundary = boundaryString.getBytes("utf-8");
stream = new PushbackInputStream(message.getContent(InputStream.class),
- boundary.length * 2);
+ pbAmount);
if (!readTillFirstBoundary(stream, boundary)) {
throw new IOException("Couldn't find MIME boundary: " + boundaryString);
}
@@ -118,7 +119,7 @@
throw new RuntimeException(e);
}
- body = new DelegatingInputStream(new MimeBodyPartInputStream(stream, boundary));
+ body = new DelegatingInputStream(new MimeBodyPartInputStream(stream, boundary, pbAmount));
message.setContent(InputStream.class, body);
}
}
@@ -286,7 +287,7 @@
* @throws IOException
*/
private void setupAttachment(AttachmentImpl att, InternetHeaders headers) throws IOException {
- MimeBodyPartInputStream partStream = new MimeBodyPartInputStream(stream, boundary);
+ MimeBodyPartInputStream partStream = new MimeBodyPartInputStream(stream, boundary, pbAmount);
final String ct = headers.getHeader("Content-Type", null);
DataSource source = new AttachmentDataSource(ct, new DelegatingInputStream(partStream));
Modified: cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java?rev=718620&r1=718619&r2=718620&view=diff
==============================================================================
--- cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java (original)
+++ cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/AttachmentUtil.java Tue Nov 18 06:37:41 2008
@@ -30,7 +30,9 @@
import org.apache.cxf.message.Attachment;
public final class AttachmentUtil {
-
+ private static volatile int counter;
+ private static final String ATT_UUID = UUID.randomUUID().toString();
+
private AttachmentUtil() {
}
@@ -42,7 +44,8 @@
public static String createContentID(String ns) throws UnsupportedEncodingException {
// tend to change
String cid = "http://cxf.apache.org/";
- String name = UUID.randomUUID().toString();
+ //String name = UUID.randomUUID().toString();
+ String name = ATT_UUID + String.valueOf(++counter);
if (ns != null && (ns.length() > 0)) {
try {
URI uri = new URI(ns);
Modified: cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java?rev=718620&r1=718619&r2=718620&view=diff
==============================================================================
--- cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java (original)
+++ cxf/trunk/rt/core/src/main/java/org/apache/cxf/attachment/MimeBodyPartInputStream.java Tue Nov 18 06:37:41 2008
@@ -28,13 +28,157 @@
PushbackInputStream inStream;
boolean boundaryFound;
-
+ int pbAmount;
byte[] boundary;
+ byte[] boundaryBuffer;
- public MimeBodyPartInputStream(PushbackInputStream inStreamParam, byte[] boundaryParam) {
+ public MimeBodyPartInputStream(PushbackInputStream inStreamParam,
+ byte[] boundaryParam,
+ int pbsize) {
super();
this.inStream = inStreamParam;
this.boundary = boundaryParam;
+ this.pbAmount = pbsize;
+ }
+
+ public int read(byte buf[], int origOff, int origLen) throws IOException {
+ byte b[] = buf;
+ int off = origOff;
+ int len = origLen;
+ if (boundaryFound) {
+ return -1;
+ }
+ if ((off < 0) || (off > b.length) || (len < 0)
+ || ((off + len) > b.length) || ((off + len) < 0)) {
+
+ throw new IndexOutOfBoundsException();
+ }
+ if (len == 0) {
+ return 0;
+ }
+ boolean bufferCreated = false;
+ if (len < boundary.length * 2) {
+ //buffer is too short to detect boundaries with it. We'll need to create a larger buffer
+ bufferCreated = true;
+ if (boundaryBuffer == null) {
+ boundaryBuffer = new byte[boundary.length * 2];
+ }
+ b = boundaryBuffer;
+ off = 0;
+ len = boundaryBuffer.length;
+ }
+ if (len > pbAmount) {
+ len = pbAmount; //can only pushback that much so make sure we can
+ }
+ if (len > 0) {
+ len = inStream.read(b, off, len);
+ }
+ int i = processBuffer(b, off, len);
+ if (bufferCreated && i > 0) {
+ // read more than we need, push it back
+ if (origLen >= i) {
+ System.arraycopy(b, 0, buf, origOff, i);
+ } else {
+ System.arraycopy(b, 0, buf, origOff, origLen);
+ inStream.unread(b, origLen, i - origLen);
+ i = origLen;
+ }
+ } else if (i == 0 && boundaryFound) {
+ return -1;
+ }
+ return i;
+ }
+
+ //Has Data after encountering CRLF
+ private boolean hasData(byte[] b, int initialPointer, int pointer, int off, int len)
+ throws IOException {
+ if (pointer < (off + len)) {
+ return true;
+ } else {
+ inStream.unread(b, initialPointer, (off + len) - initialPointer);
+ return false;
+ }
+ }
+
+ protected int processBuffer(byte[] buffer, int off, int len) throws IOException {
+ for (int i = off; i < (off + len); i++) {
+ boolean needUnread0d0a = false;
+ int value = buffer[i];
+ int initialI = i;
+ if (value == 13) {
+ if (!hasData(buffer, initialI, initialI + 1, off, len)) {
+ return initialI - off;
+ }
+ value = buffer[initialI + 1];
+ if (value != 10) {
+ continue;
+ } else { //if it comes here then 13, 10 are values and will try to match boundaries
+ if (!hasData(buffer, initialI, initialI + 2, off, len)) {
+ return initialI - off;
+ }
+ value = buffer[initialI + 2];
+ if ((byte) value != boundary[0]) {
+ i++;
+ continue;
+ } else { //13, 10, boundaries first value matched
+ needUnread0d0a = true;
+ i += 2; //i after this points to boundary[0] element
+ }
+ }
+ } else if (value != boundary[0]) {
+ continue;
+ }
+
+ int boundaryIndex = 0;
+ while ((boundaryIndex < boundary.length) && (value == boundary[boundaryIndex])) {
+ if (!hasData(buffer, initialI, i + 1, off, len)) {
+ return initialI - off;
+ }
+ value = buffer[++i];
+ boundaryIndex++;
+ }
+ if (boundaryIndex == boundary.length) {
+ // read the end of line character
+ if (initialI != off) {
+ i = 1000000000;
+ }
+ if (!hasData(buffer, initialI, i + 1, off, len)) {
+ return initialI - off;
+ }
+ boundaryFound = true;
+ int j = i + 1;
+ if (j < len && buffer[j] == 45 && value == 45) {
+ // Last mime boundary should have a succeeding "--"
+ // as we are on it, read the terminating CRLF
+ i += 2;
+ //last mime boundary
+ }
+
+ //boundary matched (may or may not be last mime boundary)
+ int processed = initialI - off;
+ if ((len - (i + 2)) > 0) {
+ inStream.unread(buffer, i + 2, len - (i + 2));
+ }
+ return processed;
+ }
+
+ // Boundary not found. Restoring bytes skipped.
+ // write first skipped byte, push back the rest
+ if (value != -1) { //pushing back first byte of boundary
+ // Stream might have ended
+ i--;
+ }
+ if (needUnread0d0a) { //Pushing all, returning 13
+ i = i - boundaryIndex;
+ i--; //for 10
+ value = 13;
+ } else {
+ i = i - boundaryIndex;
+ i++;
+ value = boundary[0];
+ }
+ }
+ return len;
}
public int read() throws IOException {