[GitHub] [incubator-doris] morningman commented on a change in pull request #4005: LRU cache for sql/partition cache #2581

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4005:
URL: https://github.com/apache/incubator-doris/pull/4005#discussion_r449113739



##########
File path: be/src/common/config.h
##########
@@ -536,6 +536,15 @@ namespace config {
     // Whether to continue to start be when load tablet from header failed.
     CONF_Bool(ignore_load_tablet_failure, "false");
 
+    // Set max cache's size of query results, the unit is M byte
+    CONF_Int32(cache_max_size, "256"); 

Review comment:
       ```suggestion
       CONF_Int32(query_cache_max_size_mb, "256"); 
   ```
   
   same suggestion for other 2 configs.

##########
File path: be/src/util/doris_metrics.cpp
##########
@@ -161,6 +158,10 @@ DorisMetrics::DorisMetrics() : _name("doris_be"), _hook_name("doris_metrics"), _
     REGISTER_DORIS_METRIC(tablet_cumulative_max_compaction_score);
     REGISTER_DORIS_METRIC(tablet_base_max_compaction_score);
 
+    REGISTER_DORIS_METRIC(cache_memory_total);

Review comment:
       ```suggestion
       REGISTER_DORIS_METRIC(query_cache_memory_total_mb);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org