[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

[GitBox <gi...@apache.org>]

A-Wanderer commented on a change in pull request #14604:
URL: https://github.com/apache/pulsar/pull/14604#discussion_r825624655



##########
File path: pulsar-client-cpp/lib/ConsumerImpl.cc
##########
@@ -1229,7 +1244,17 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, ResultCallback callback) {
         LOG_DEBUG(getName() << " Sending seek Command for Consumer - " << getConsumerId() << ", requestId - "
                             << requestId);
         Future<Result, ResponseData> future =
-            cnx->sendRequestWithId(Commands::newSeek(consumerId_, requestId, msgId), requestId);
+            msgId.isChunkMessageid()
+                ? cnx->sendRequestWithId(
+                      Commands::newSeek(consumerId_, requestId,
+                                        std::dynamic_pointer_cast<ChunkMessageIdImpl>(msgId.impl_)
+                                            ->getFirstChunkMessageIdImpl()

Review comment:
       When ChunkMessageIdImpl be constructed, it must need the param of FirstChunkMessageIdImpl, so i think dont need to check here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org