[jira] [Commented] (HIVE-10632) Make sure TXN_COMPONENTS gets cleaned up if table is dropped before compaction.

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172854#comment-15172854 ] 

Alan Gates commented on HIVE-10632:
-----------------------------------

TxnHandler.cleanupRecords For the first argument, enums or at least final statics are better than magic characters.

TxnUtils.isAcidTable, I don't think we need to check beyond whether a table is marked transactional.  If it's marked as transactional let's just take that as the truth and throw an error if we discover some other issue like it's not bucketed or whatever.

Other than that, looks good.

> Make sure TXN_COMPONENTS gets cleaned up if table is dropped before compaction.
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-10632
>                 URL: https://issues.apache.org/jira/browse/HIVE-10632
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore, Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Wei Zheng
>            Priority: Critical
>         Attachments: HIVE-10632.1.patch, HIVE-10632.2.patch, HIVE-10632.3.patch, HIVE-10632.4.patch, HIVE-10632.5.patch
>
>
> The compaction process will clean up entries in  TXNS, COMPLETED_TXN_COMPONENTS, TXN_COMPONENTS.  If the table/partition is dropped before compaction is complete there will be data left in these tables.  Need to investigate if there are other situations where this may happen and address it.
> see HIVE-10595 for additional info



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)