You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/01/23 20:49:09 UTC

[PR] Remove dns-java workarounds [polaris]

adutra opened a new pull request, #863:
URL: https://github.com/apache/polaris/pull/863

   The latest 3.6.2 version seems to fix the issue. I also tested with Postgres using the docker-compose files from #859 and had no issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2611138012

   @adutra : IIRC, `dnsjava` used to break EclipseLink with PosgreSQL. Did you have a change to test that? If bootstrap with PostgreSQL works, that's a good enough test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2611072180

   https://github.com/projectnessie/nessie/pull/9951 and https://github.com/projectnessie/nessie/issues/9943 have some context. I _think_ there was a problem with how dnsjava.jar was built (mr-jar) - and the Java runtime version - and likely, as you said, whether it's then run in an uber-jar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2612169641

   > @adutra : IIRC, `dnsjava` used to break EclipseLink with PostgreSQL. Did you have a change to test that? If bootstrap with PostgreSQL works, that's a good enough test.
   > 
   > Update: for extra certainty I think we ought to test on local machines :)
   
   I tested with the new docker-compose files from #859 which include an example with EclispeLink and Postgres. Do you think that's enough?
   
   > Java version may also be a factor.
   
   I only tested with Java 21.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2611022742

   > FYI the latest dnsjava versions come with `META-INF/services/java.net.spi.InetAddressResolverProvider` referencing their custom DNS resolver. But IIRC, that needs to be explicitly enabled via a system property.
   
   Indeed, that SPI impl was introduced in 3.6.0 and is enabled by a system property: `org.dnsjava.spi.enable`.  I do not fully understand why the problem occurred, and why it disappeared. Maybe related to the switch to Quarkus and/or the fact that we don't produce shaded artifacts anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #863:
URL: https://github.com/apache/polaris/pull/863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2612221516

   > I only tested with Java 21.
   
   I guess that's fine then. The runtime requires Java 21.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2610991280

   Relates to #583 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2611142415

   Java version may also be a factor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove dns-java workarounds [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #863:
URL: https://github.com/apache/polaris/pull/863#issuecomment-2611001319

   FYI the latest dnsjava versions come with `META-INF/services/java.net.spi.InetAddressResolverProvider` referencing their custom DNS resolver. But IIRC, that needs to be explicitly enabled via a system property.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org