[GitHub] [guacamole-server] mike-jumper commented on pull request #350: GUACAMOLE-943 Fixed incorrect sequence for SSH and telnet when shift key is held.

[GitBox <gi...@apache.org>]

mike-jumper commented on pull request #350:
URL: https://github.com/apache/guacamole-server/pull/350#issuecomment-961659983


   For something like Ctrl+Alt+Shift where the mainline webapp reserves that
   key combination for itself, you will likely need to either use Guacamole's
   on-screen keyboard or send the key events programmatically with guac's JS
   API.
   
   On Thu, Nov 4, 2021, 23:24 Noor-glyp ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In src/terminal/terminal.c
   > <https://github.com/apache/guacamole-server/pull/350#discussion_r743413152>
   > :
   >
   > > +            if (term->mod_shift)
   > +            {
   >
   >
   >    1. I resolved the formatting issue. And rewrote the commit message.
   >    2. Well if function key is pressed without Shift and with Shift. Both
   >    generate different key events. For the Ctrl+Function or Ctrl+Alt function
   >    or Ctrl+Alt+Shift +Function (This opens the menu and refocuses it to menu
   >    so function key hold with it, I am not sure the function key event will
   >    pass through.)
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/guacamole-server/pull/350#discussion_r743413152>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABDLCSOAGW3RTDWQXQ3GRBLUKN2DVANCNFSM5HKUFPBQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org