You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "rienzi2012 (JIRA)" <ji...@apache.org> on 2015/12/01 14:38:11 UTC
[jira] [Updated] (TS-4046) HdrHeap and HdrStrHeap leak in
HttpTransact::EndRemapRequest
[ https://issues.apache.org/jira/browse/TS-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rienzi2012 updated TS-4046:
---------------------------
Description:
HTTPHdr::clear is called instead of HdrHeapSDKHandle::destroy() in HttpTransact::EndRemapRequest. This will definitely cause memory leak when a plugin calls TSHttpTxnServerIntercept or TSHttpTxnIntercept. This bug influences a lot of users. Here is a patch below.
{code:java}
@@ -892,7 +892,7 @@
HTTP_INCREMENT_TRANS_STAT(http_invalid_client_requests_stat);
TRANSACT_RETURN(SM_ACTION_SEND_ERROR_CACHE_NOOP, NULL);
} else {
- s->hdr_info.client_response.clear(); // anything previously set is invalid from this point forward
+ s->hdr_info.client_response.destroy();
DebugTxn("http_trans", "END HttpTransact::EndRemapRequest");
if (s->is_upgrade_request && s->post_remap_upgrade_return_point) {
{code}
was:
{code:java}
@@ -892,7 +892,7 @@
HTTP_INCREMENT_TRANS_STAT(http_invalid_client_requests_stat);
TRANSACT_RETURN(SM_ACTION_SEND_ERROR_CACHE_NOOP, NULL);
} else {
- s->hdr_info.client_response.clear(); // anything previously set is invalid from this point forward
+ s->hdr_info.client_response.destroy();
DebugTxn("http_trans", "END HttpTransact::EndRemapRequest");
if (s->is_upgrade_request && s->post_remap_upgrade_return_point) {
{code}
> HdrHeap and HdrStrHeap leak in HttpTransact::EndRemapRequest
> ------------------------------------------------------------
>
> Key: TS-4046
> URL: https://issues.apache.org/jira/browse/TS-4046
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP, MIME, Plugins
> Reporter: rienzi2012
>
> HTTPHdr::clear is called instead of HdrHeapSDKHandle::destroy() in HttpTransact::EndRemapRequest. This will definitely cause memory leak when a plugin calls TSHttpTxnServerIntercept or TSHttpTxnIntercept. This bug influences a lot of users. Here is a patch below.
> {code:java}
> @@ -892,7 +892,7 @@
> HTTP_INCREMENT_TRANS_STAT(http_invalid_client_requests_stat);
> TRANSACT_RETURN(SM_ACTION_SEND_ERROR_CACHE_NOOP, NULL);
> } else {
> - s->hdr_info.client_response.clear(); // anything previously set is invalid from this point forward
> + s->hdr_info.client_response.destroy();
> DebugTxn("http_trans", "END HttpTransact::EndRemapRequest");
>
> if (s->is_upgrade_request && s->post_remap_upgrade_return_point) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)