You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2016/03/25 07:09:25 UTC
[jira] [Commented] (LUCENE-6871) Move SpanQueries out of .spans
package
[ https://issues.apache.org/jira/browse/LUCENE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211471#comment-15211471 ]
Robert Muir commented on LUCENE-6871:
-------------------------------------
Besides the impedence mismatch (working on ranges of positions versus documents), i still see the spans as being pretty sandy. Really they belong in the sandbox :)
They've got crazy apis, inefficient apis, straight up ugly apis, and even whole span queries that probably should not exist (FieldMasking). I don't think we should mix them in with our core queries like TermQuery at the moment? But that's just me.
> Move SpanQueries out of .spans package
> --------------------------------------
>
> Key: LUCENE-6871
> URL: https://issues.apache.org/jira/browse/LUCENE-6871
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 5.4, master
> Reporter: Alan Woodward
> Attachments: LUCENE-6871.patch, LUCENE-6871.patch
>
>
> SpanQueries are now essentially the same as a standard query, restricted to a single field and with an extra scorer type returned by getSpans(). There are a number of existing queries that fit this contract, including TermQuery and PhraseQuery, and it should be possible to make them SpanQueries as well without impacting their existing performance. However, we can't do this while SpanQuery and its associated Weight and Spans classes are in their own package.
> I'd like to remove the o.a.l.search.spans package entirely, in a few stages:
> 1) Move SpanQuery, SpanWeight, Spans, SpanCollector and FilterSpans to o.a.l.search
> 2) Remove SpanTermQuery and merge its functionality into TermQuery
> 3) Move SpanNear, SpanNot, SpanOr and SpanMultiTermQueryWrapper to o.a.l.search
> 4) Move the remaining SpanQueries to the queries package
> Then we can look at, eg, making PhraseQuery a SpanQuery, removing SpanMTQWrapper and making MultiTermQuery a SpanQuery, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org