[GitHub] [spark] LantaoJin commented on a change in pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

[GitBox <gi...@apache.org>]

LantaoJin commented on a change in pull request #29156:
URL: https://github.com/apache/spark/pull/29156#discussion_r457002916



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##########
@@ -165,6 +165,24 @@ object ResolveHints {
           hintErrorHandler.hintRelationsNotFound(h.name, h.parameters, unmatchedIdents)
           applied
         }
+      case With(child, relations) => resolveCTEHint(child,

Review comment:
       This patch looks like it is specifically designed to fix `With` comparing to #29062. I am open to more comments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org