[GitHub] [knox] smolnar82 commented on a change in pull request #304: KNOX-2315 - Fix zookeeper Kerberos Auth

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #304: KNOX-2315 - Fix zookeeper Kerberos Auth
URL: https://github.com/apache/knox/pull/304#discussion_r403914761
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/ZookeeperRemoteAliasService.java
 ##########
 @@ -127,9 +156,18 @@ private static void ensureEntry(final String path, final RemoteConfigurationRegi
                     // content may not be trustworthy.
                     if (remoteClient.isAuthenticationConfigured()) {
                         LOG.correctingSuspectWritableRemoteConfigurationEntry(path);
-
                         // Replace the existing ACL with one that permits only authenticated users
-                        remoteClient.setACL(path, Collections.singletonList(AUTHENTICATED_USERS_ALL));
+                        if (remoteClient.authenticationType()
 
 Review comment:
   `.authenticationType()` may be NULL (see `LocalFileSystemRemoteConfigurationRegistryClientService` implementation below) -> `remoteClient.authenticationType().equalsIgnoreCase("Kerberos")` may throw a NPE.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services