You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2014/07/30 20:25:10 UTC

[GitHub] spark pull request: Fix maven build.

GitHub user yhuai opened a pull request:

    https://github.com/apache/spark/pull/1664

    Fix maven build.

    This PR aims to fix the maven build broken by #1346.
    I tried (based on the commands used by jenkins)
    ```
    mvn -Dhadoop.version=2.0.0-mr1-cdh4.1.2 -DskipTests clean package
    
    mvn -DHADOOP_PROFILE=hadoop-2.4 -DskipTests -Phadoop-2.4 -Pyarn -Phive clean package
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yhuai/spark fixMavenBuild

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1664
    
----
commit c7f42e56b4713d2a94a154b872832b81d627cb2b
Author: Yin Huai <hu...@cse.ohio-state.edu>
Date:   2014-07-30T18:23:07Z

    Fix maven build.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Fix maven build.

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/1664#issuecomment-50658592
  
    I already submitted a PR earlier today: https://github.com/apache/spark/pull/1660
    I think that is a slightly more suitable fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Fix maven build.

Posted by yhuai <gi...@git.apache.org>.

Github user yhuai closed the pull request at:

    https://github.com/apache/spark/pull/1664


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Fix maven build.

Posted by yhuai <gi...@git.apache.org>.

Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/1664#issuecomment-50659106
  
    @srowen Thank you. I am closing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---