[GitHub] [apisix-dashboard] membphis commented on a change in pull request #370: feat: Unified access entrance, only the dashboard port is exposed to …

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #370:
URL: https://github.com/apache/apisix-dashboard/pull/370#discussion_r467894334



##########
File path: compose/dashboard_conf/nginx.conf
##########
@@ -0,0 +1,21 @@
+server {
+    listen 80;
+    # gzip config
+    gzip on;
+    gzip_min_length 1k;
+    gzip_comp_level 9;
+    gzip_types text/plain text/css text/javascript application/json application/javascript application/x-javascript application/xml;
+    gzip_vary on;
+    gzip_disable "MSIE [1-6]\.";
+
+    root /usr/share/nginx/html;
+    include /etc/nginx/mime.types;
+
+    location / {
+        try_files $uri $uri/ /index.html;
+    }
+
+    location /apisix/admin {
+        proxy_pass http://manager:8080/apisix/admin;
+    }
+}

Review comment:
       need a blank line at the end of file

##########
File path: compose/dashboard_conf/nginx.conf
##########
@@ -0,0 +1,21 @@
+server {
+    listen 80;
+    # gzip config
+    gzip on;

Review comment:
       why do we need to enable `gzip` by default? I think `off` is better for us.
   
   only CDN need to open `gzip` by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org