[jira] [Commented] (METRON-1290) Only first 10 alerts are update when a MetaAlert status is changed to inactive

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235742#comment-16235742 ] 

ASF GitHub Bot commented on METRON-1290:
----------------------------------------

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/825

    METRON-1290: Only first 10 alerts are update when a MetaAlert status is changed to inactive

    ## Contributor Comments
    This PR fixes a small bug in the ElasticsearchMetaAlertDao that only updates the first 10 alerts in a metaalert when that metaalert status is changed to inactive.  This is due to the fact that the ElasticsearchMetaAlertDao needs to lookup up the child alerts and a search created with `elasticsearchDao.getClient().prepareSearch()` defaults to result set size to 10.  This can be reproduced in full dev:
    - turn off the sensor stubs so that the number of alerts in ES is fixed
    - take note of the number of alerts in the index
    - create a metaalert with more than 10 alerts
    - the number of alerts should decrease to: # of alerts added - 1 metaalert
    - change the metaalert status to inactive 
    - the number of alerts will now be less than before where the count should be the same
    
    I also added an embarrassingly complex unit test to cover this situation.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1290

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #825
    
----
commit 9159ee5e2ccba4a762b6f3a455130a1da79d4c70
Author: merrimanr <me...@gmail.com>
Date:   2017-11-02T13:25:47Z

    initial commit

----


> Only first 10 alerts are update when a MetaAlert status is changed to inactive
> ------------------------------------------------------------------------------
>
>                 Key: METRON-1290
>                 URL: https://issues.apache.org/jira/browse/METRON-1290
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)