You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2017/08/23 16:37:27 UTC
Review Request 61851: HIVE-17318: Make Hikari configurable using hive
properties in hive-site.xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61851/
-----------------------------------------------------------
Review request for hive and Peter Vary.
Bugs: HIVE-17318
https://issues.apache.org/jira/browse/HIVE-17318
Repository: hive-git
Description
-------
HIVE-17318: Make Hikari configurable using hive properties in hive-site.xml
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java fa6bb1cc5252a71ccc6f011d5dd062a952de5b8a
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java PRE-CREATION
metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java 628460482dc646f8a38f607e815eddaa3cc2a831
Diff: https://reviews.apache.org/r/61851/diff/1/
Testing
-------
Thanks,
Barna Zsombor Klara
Re: Review Request 61851: HIVE-17318: Make Hikari configurable using
hive properties in hive-site.xml
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61851/#review183655
-----------------------------------------------------------
Thanks for the patch Zsombor!
Just one minor comment.
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java
Lines 38 (patched)
<https://reviews.apache.org/r/61851/#comment259727>
Shouldn't we set the hikari configurations to HIVE_CONF_RESTRICTED_LIST as well?
See: "bonecp."
- Peter Vary
On Aug. 23, 2017, 4:45 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61851/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2017, 4:45 p.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Bugs: HIVE-17318
> https://issues.apache.org/jira/browse/HIVE-17318
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17318: Make Hikari configurable using hive properties in hive-site.xml
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java fa6bb1cc5252a71ccc6f011d5dd062a952de5b8a
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java a6d56137b3c4501b74b1e9a3c5d4085b55919710
> metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java 628460482dc646f8a38f607e815eddaa3cc2a831
>
>
> Diff: https://reviews.apache.org/r/61851/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 61851: HIVE-17318: Make Hikari CP configurable
using hive properties in hive-site.xml
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61851/#review183725
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Vary
On Aug. 24, 2017, 9:43 a.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61851/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2017, 9:43 a.m.)
>
>
> Review request for hive and Peter Vary.
>
>
> Bugs: HIVE-17318
> https://issues.apache.org/jira/browse/HIVE-17318
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17318: Make Hikari CP configurable using hive properties in hive-site.xml
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2fb004c0ecea6d371a3a18e4d0eab19e5b80af55
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java fa6bb1cc5252a71ccc6f011d5dd062a952de5b8a
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java a6d56137b3c4501b74b1e9a3c5d4085b55919710
> metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java 628460482dc646f8a38f607e815eddaa3cc2a831
>
>
> Diff: https://reviews.apache.org/r/61851/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 61851: HIVE-17318: Make Hikari CP configurable
using hive properties in hive-site.xml
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61851/
-----------------------------------------------------------
(Updated Aug. 24, 2017, 9:43 a.m.)
Review request for hive and Peter Vary.
Changes
-------
Patch updated. Thanks Peter for spotting the missing restricted list setting.
Summary (updated)
-----------------
HIVE-17318: Make Hikari CP configurable using hive properties in hive-site.xml
Bugs: HIVE-17318
https://issues.apache.org/jira/browse/HIVE-17318
Repository: hive-git
Description (updated)
-------
HIVE-17318: Make Hikari CP configurable using hive properties in hive-site.xml
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2fb004c0ecea6d371a3a18e4d0eab19e5b80af55
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java fa6bb1cc5252a71ccc6f011d5dd062a952de5b8a
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java a6d56137b3c4501b74b1e9a3c5d4085b55919710
metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java 628460482dc646f8a38f607e815eddaa3cc2a831
Diff: https://reviews.apache.org/r/61851/diff/3/
Changes: https://reviews.apache.org/r/61851/diff/2-3/
Testing
-------
Thanks,
Barna Zsombor Klara
Re: Review Request 61851: HIVE-17318: Make Hikari configurable using
hive properties in hive-site.xml
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61851/
-----------------------------------------------------------
(Updated Aug. 23, 2017, 4:45 p.m.)
Review request for hive and Peter Vary.
Changes
-------
Updated changes to TxnHandler.java.
Bugs: HIVE-17318
https://issues.apache.org/jira/browse/HIVE-17318
Repository: hive-git
Description
-------
HIVE-17318: Make Hikari configurable using hive properties in hive-site.xml
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java fa6bb1cc5252a71ccc6f011d5dd062a952de5b8a
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java a6d56137b3c4501b74b1e9a3c5d4085b55919710
metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java 628460482dc646f8a38f607e815eddaa3cc2a831
Diff: https://reviews.apache.org/r/61851/diff/2/
Changes: https://reviews.apache.org/r/61851/diff/1-2/
Testing
-------
Thanks,
Barna Zsombor Klara