You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/16 13:16:14 UTC

[GitHub] [zookeeper] ravowlga123 commented on issue #1181: ZOOKEEPER-2313 Refactor ZooKeeperServerBean and its subclasses

ravowlga123 commented on issue #1181: ZOOKEEPER-2313 Refactor ZooKeeperServerBean and its subclasses
URL: https://github.com/apache/zookeeper/pull/1181#issuecomment-566056043
 
 
   Thank You for the review @maoling. I have addressed your comments in the latest commit and also made the changes in ReadOnlyBean.
   
   Regarding the test failures in previous build:
   
   - org.apache.zookeeper.server.quorum.LeaderBeanTest.testGetName: Was because of different name given in previous commit. This should pass now.
   - org.apache.zookeeper.test.ObserverMasterTest.testAdminCommands and org.apache.zookeeper.test.QuorumMajorityTest.testMajQuorums were not failing locally.
   
   Please do let me know if you find something wrong with latest commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services