You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/11/13 04:40:51 UTC

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64 

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18022


Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................

IMPALA-11005 (part 3): Repalce random number generator with mt19937_64

Previous patch upgraded boost library. This patch changes 64-bit random
number generator from ranlux64_3 to mt19937_64 since mt19937_64 has
better performance according to boost benchmark at https://www.boost.org
/doc/libs/1_74_0/doc/html/boost_random/performance.html.
Also fixs an unit-test which is affected by the change of random number
generator.

Testing:
 - Passed exhaustive tests.

Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
---
M be/src/exprs/aggregate-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/alloc-fail-init.test
2 files changed, 7 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/18022/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7706/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 22:58:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7708/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 05:33:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9774/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Nov 2021 05:03:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 05:33:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 2: Code-Review+2

This makes sense to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 21:33:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7706/


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 05:22:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 3:

Hit IMPALA-10999.


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 05:32:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 22:58:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 11:49:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11005 (part 3): Repalce random number generator with mt19937 64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18022 )

Change subject: IMPALA-11005 (part 3): Repalce random number generator with mt19937_64
......................................................................

IMPALA-11005 (part 3): Repalce random number generator with mt19937_64

Previous patch upgraded boost library. This patch changes 64-bit random
number generator from ranlux64_3 to mt19937_64 since mt19937_64 has
better performance according to boost benchmark at https://www.boost.org
/doc/libs/1_74_0/doc/html/boost_random/performance.html.
Also fixs an unit-test which is affected by the change of random number
generator.

Testing:
 - Passed exhaustive tests.

Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Reviewed-on: http://gerrit.cloudera.org:8080/18022
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/aggregate-functions-ir.cc
M testdata/workloads/functional-query/queries/QueryTest/alloc-fail-init.test
2 files changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iade226fc17442f4d7b9b14e4a9e80a30a3856226
Gerrit-Change-Number: 18022
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>